distsql, store/tikv: refine metrics. #2460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make metrics records helpful information.
disksing
reviewed
Jan 14, 2017
| resp, err := it.handleTask(bo, task) | ||
| coprocessorHistogram.Observe(time.Since(startTime).Seconds()) | ||
| backoffHistogram.Observe(float64(bo.totalSleep) / 1000) |
There was a problem hiding this comment.
It will record many 0 values.
There was a problem hiding this comment.
This is intended, we need task time subtract backoff time to get the pure coprocessor time.
There was a problem hiding this comment.
What does 'pure coprocessor time' mean exactly?
We already have tidb_tikvclient_request_seconds{type="cop"} for the request round trip, and also tikv_coprocessor_request_duration_seconds_bucket on server side. It may not be necessary to use subtraction.
|
LGTM |
|
@disksing PTAL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make metrics more helpful.