Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor: update tipb, use shared bytes #2806

Merged
merged 1 commit into from Mar 10, 2017
Merged

vendor: update tipb, use shared bytes #2806

merged 1 commit into from Mar 10, 2017

Conversation

@coocood
Copy link
Member

@coocood coocood commented Mar 10, 2017

Reduce memory allocation.

Heap stats after scan 1 million record table:

before:

# Alloc = 1617988216
# TotalAlloc = 5759754344

after:

# Alloc = 1305848152
# TotalAlloc = 4735086792

The next step is to update kvproto to use shared bytes.

Reduce memory allocation.
@hanfei1991
Copy link
Member

@hanfei1991 hanfei1991 commented Mar 10, 2017

LGTM

1 similar comment
@tiancaiamao
Copy link
Contributor

@tiancaiamao tiancaiamao commented Mar 10, 2017

LGTM

@coocood coocood merged commit 27405e8 into master Mar 10, 2017
4 checks passed
4 checks passed
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
@coocood coocood deleted the coocood/update-tipb branch Mar 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.