Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: fix license header #28085

Merged
merged 6 commits into from Sep 17, 2021
Merged

*: fix license header #28085

merged 6 commits into from Sep 17, 2021

Conversation

tisonkun
Copy link
Contributor

Signed-off-by: tison wander4096@gmail.com

What problem does this PR solve?

Issue Number: close #27356

Release note

None

@tisonkun
*: fix license header
7b18587 
Signed-off-by: tison <wander4096@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 16, 2021 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • disksing
  • zhouqiang-cl

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 16, 2021
@tisonkun
Copy link
Contributor Author

/cc @bb7133 @disksing

disksing
disksing reviewed Sep 17, 2021
View reviewed changes
table/table.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 17, 2021
zhouqiang-cl
zhouqiang-cl approved these changes Sep 17, 2021
View reviewed changes
Copy link
Contributor

@zhouqiang-cl zhouqiang-cl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 17, 2021
@zhouqiang-cl
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 3b21212

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 17, 2021
@ti-chi-bot ti-chi-bot merged commit 680de92 into pingcap:master Sep 17, 2021
@tisonkun tisonkun deleted the license-header branch September 18, 2021 17:10
@DavidKorczynski
Copy link

I noticed that the OSS-Fuzz build has not been working since this PR. This is because this PR removes the 3 files containing fuzzers - is this intentional, i.e. do you not want your project fuzzed?

@DavidKorczynski DavidKorczynski mentioned this pull request Oct 18, 2021
Open
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@disksing disksing disksing approved these changes

@zhouqiang-cl zhouqiang-cl zhouqiang-cl approved these changes

@bb7133 bb7133 Awaiting requested review from bb7133

Assignees
No one assigned
Labels
release-note-none size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tracking issue for handling illegal license header
5 participants
@tisonkun @ti-chi-bot @zhouqiang-cl @DavidKorczynski @disksing