Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compatibility: SQL_SELECT_LIMIT worked in show statement; #33696

Merged
merged 4 commits into from Sep 28, 2022
Merged

Compatibility: SQL_SELECT_LIMIT worked in show statement; #33696

merged 4 commits into from Sep 28, 2022

Conversation

Benjamin2037
Copy link
Collaborator

@Benjamin2037 Benjamin2037 commented Apr 2, 2022 •
edited

issue #33407

What problem does this PR solve?

Issue Number: close #33407

Problem Summary:

What is changed and how it works?

The supported Show stmts are go through to find out what stmts should be influenced by SelectLimit value on return result set row numbers. The Limit executor is added into plan tree for show stmts to archieve the requirement.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 2, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lcwangchao
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 2, 2022
@Benjamin2037
Copy link
Collaborator Author

/run-mysql-test

@sre-bot
Copy link
Contributor

sre-bot commented Apr 2, 2022 •
edited

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/13bc294f5678a0f92e25f5ed90a04bdd07cf06b4

@Benjamin2037 Benjamin2037 force-pushed the show_stmt_compatibility_enhance branch from e41a74e to 3173451 Compare April 5, 2022 03:23
@Benjamin2037
Copy link
Collaborator Author

/run-mysql-test

@Benjamin2037 Benjamin2037 force-pushed the show_stmt_compatibility_enhance branch from f4489c1 to 7558dfd Compare April 7, 2022 09:53
@Benjamin2037 Benjamin2037 force-pushed the show_stmt_compatibility_enhance branch 2 times, most recently from b975684 to 6807470 Compare April 12, 2022 10:47
@Benjamin2037
Copy link
Collaborator Author

/run-mysql-test

lcwangchao
lcwangchao reviewed Apr 12, 2022
View reviewed changes
Copy link
Collaborator

@lcwangchao lcwangchao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

executor/show.go Show resolved Hide resolved
@Benjamin2037 Benjamin2037 force-pushed the show_stmt_compatibility_enhance branch 2 times, most recently from 36c5c88 to 13bc294 Compare April 13, 2022 01:31
@Benjamin2037
Copy link
Collaborator Author

/run-mysql-test

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 26, 2022
@Benjamin2037 Benjamin2037 requested a review from a team as a code owner September 28, 2022 01:43
@ti-chi-bot ti-chi-bot removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 28, 2022
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 28, 2022
@Benjamin2037 Benjamin2037 removed request for a team and wjhuang2016 September 28, 2022 01:48
@Benjamin2037
Copy link
Collaborator Author

Rest LGTM

Please Approve

@Benjamin2037
Copy link
Collaborator Author

/run-unit-test

@Benjamin2037 Benjamin2037 removed the request for review from xhebox September 28, 2022 02:30
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 28, 2022
@Benjamin2037
Copy link
Collaborator Author

/run-mysql-test

xhebox
xhebox reviewed Sep 28, 2022
View reviewed changes
Copy link
Contributor

@xhebox xhebox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

executor/show.go Show resolved Hide resolved
@Benjamin2037
Copy link
Collaborator Author

/run-mysql-test

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 28, 2022
@xhebox
Copy link
Contributor

xhebox commented Sep 28, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 19426fa

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 28, 2022
@ti-chi-bot ti-chi-bot merged commit 3f85f8e into pingcap:master Sep 28, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Sep 28, 2022

TiDB MergeCI notify

🔴 Bad News! [1] CI still failing after this pr merged.
These failed integration tests don't seem to be introduced by the current PR.

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/common-test 🔴 failed 1, success 10, total 11 8 min 45 sec Existing failure
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 30 min Existing passed
idc-jenkins-ci/integration-cdc-test 🟢 all 37 tests passed 25 min Existing passed
idc-jenkins-ci-tidb/integration-common-test 🟢 all 17 tests passed 15 min Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 6 min 4 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 5 min 46 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 5 min 23 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 2 min 53 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 2 min 43 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

@Benjamin2037 Benjamin2037 deleted the show_stmt_compatibility_enhance branch October 9, 2022 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lcwangchao lcwangchao lcwangchao approved these changes

@xhebox xhebox xhebox approved these changes

@chrysan chrysan Awaiting requested review from chrysan

@hawkingrei hawkingrei Awaiting requested review from hawkingrei

@xiongjiwei xiongjiwei Awaiting requested review from xiongjiwei

Assignees
No one assigned
Labels
release-note-none size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SQL_SELECT_LIMIT worked with show columns in MYSQL but not in TIDB
5 participants
@Benjamin2037 @ti-chi-bot @sre-bot @xhebox @lcwangchao