Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: fix show create table with set and enum #36327

Merged
merged 7 commits into from Jul 19, 2022
Merged

executor: fix show create table with set and enum #36327

merged 7 commits into from Jul 19, 2022

Conversation

Defined2014
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #36317

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

fix `show create table` with `set` and `enum` type

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 19, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hawkingrei
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 19, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jul 19, 2022 •
edited

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/8c9ac5daca90e88e58c78de9fb3d2087f254e7ac

@Defined2014
Copy link
Contributor Author

/run-mysql-test pr=tidb-test/pull/1892

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 19, 2022
@Defined2014
Copy link
Contributor Author

/run-mysql-test tidb-test=pr/1892

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 19, 2022
@Defined2014
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 8bd6d29

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 19, 2022
@Defined2014
Copy link
Contributor Author

/run-mysql-test tidb-test=pr/1892

1 similar comment
@Defined2014
Copy link
Contributor Author

/run-mysql-test tidb-test=pr/1892

@Defined2014
Copy link
Contributor Author

/run-mysql-test tidb-test=pr/1892

@Defined2014
Copy link
Contributor Author

/run-mysql-test tidb-test=pr/1892

1 similar comment
@Defined2014
Copy link
Contributor Author

/run-mysql-test tidb-test=pr/1892

@Defined2014
Copy link
Contributor Author

/run-mysql-test tidb-test=pr/1892

@ti-chi-bot ti-chi-bot merged commit a0cced2 into pingcap:master Jul 19, 2022
@Defined2014 Defined2014 deleted the fix-36317 branch July 19, 2022 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkingrei hawkingrei hawkingrei approved these changes

@xhebox xhebox xhebox approved these changes

@BornChanger BornChanger Awaiting requested review from BornChanger

Assignees
No one assigned
Labels
release-note size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

show create table with set is not compatible with mysql
5 participants
@Defined2014 @ti-chi-bot @sre-bot @hawkingrei @xhebox