New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression, json: fix a bug of json_unquote. #3764

Merged
merged 3 commits into from Jul 17, 2017

Conversation

Projects
None yet
4 participants
@hicqu
Contributor

hicqu commented Jul 15, 2017

for this statement:

select json_unquote("Invalid json string");

Previously it will cause fail, but in MySQL it should success.
This PR is for fix this.

@hicqu hicqu requested review from AndreMouche, hhkbp2 and tiancaiamao Jul 15, 2017

@shenli

This comment has been minimized.

Show comment
Hide comment
@shenli

shenli Jul 15, 2017

Member

Please add description for this PR.

Member

shenli commented Jul 15, 2017

Please add description for this PR.

@tiancaiamao

This comment has been minimized.

Show comment
Hide comment
@tiancaiamao

tiancaiamao Jul 17, 2017

Contributor

LGTM

Contributor

tiancaiamao commented Jul 17, 2017

LGTM

@shenli

This comment has been minimized.

Show comment
Hide comment
@shenli

shenli Jul 17, 2017

Member

LGTM

Member

shenli commented Jul 17, 2017

LGTM

@shenli

This comment has been minimized.

Show comment
Hide comment
Member

shenli commented Jul 17, 2017

@shenli

shenli approved these changes Jul 17, 2017

@shenli shenli merged commit 5a3a8b0 into master Jul 17, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@shenli shenli deleted the json_fix branch Jul 17, 2017

dbjoa added a commit to cloud-pi/tidb that referenced this pull request Jul 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment