New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: add unit test for schema.go #3779

Merged
merged 6 commits into from Jul 18, 2017

Conversation

Projects
None yet
3 participants
@zz-jason
Member

zz-jason commented Jul 17, 2017

to #3729

Show outdated Hide outdated expression/schema_test.go
@@ -0,0 +1,280 @@
// Copyright 2015 PingCAP, Inc.

This comment has been minimized.

@XuHuaiyu

XuHuaiyu Jul 17, 2017

Contributor

s/2015/2017

@XuHuaiyu

XuHuaiyu Jul 17, 2017

Contributor

s/2015/2017

This comment has been minimized.

@zz-jason

zz-jason Jul 17, 2017

Member

done

@zz-jason

This comment has been minimized.

Show comment
Hide comment
Member

zz-jason commented Jul 17, 2017

@jackysp jackysp added the status/LGT1 label Jul 18, 2017

@XuHuaiyu

This comment has been minimized.

Show comment
Hide comment
@XuHuaiyu

XuHuaiyu Jul 18, 2017

Contributor

Can the duplicated code like
initiation of schema, colOutSchema
be extracted. @zz-jason

Contributor

XuHuaiyu commented Jul 18, 2017

Can the duplicated code like
initiation of schema, colOutSchema
be extracted. @zz-jason

zz-jason added some commits Jul 18, 2017

Show outdated Hide outdated expression/schema_test.go
func (s *testEvalSuite) TestSchemaString(c *C) {
colCount := 5
keyInfoCount := 3
func GenerateSchema(colCount int, dbName, tblName, fromID string) *Schema {

This comment has been minimized.

@XuHuaiyu

XuHuaiyu Jul 18, 2017

Contributor

We only use it in this file,
may be this function can be unexported.

Same as line43. @zz-jason

@XuHuaiyu

XuHuaiyu Jul 18, 2017

Contributor

We only use it in this file,
may be this function can be unexported.

Same as line43. @zz-jason

@XuHuaiyu

LGTM

@XuHuaiyu XuHuaiyu merged commit 8c24c01 into master Jul 18, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@XuHuaiyu XuHuaiyu deleted the 3729-ut4schema branch Jul 18, 2017

dbjoa added a commit to cloud-pi/tidb that referenced this pull request Jul 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment