New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kv (test): coverage of kv to 83% #3790

Merged
merged 4 commits into from Jul 19, 2017

Conversation

Projects
None yet
4 participants
@jackysp
Member

jackysp commented Jul 18, 2017

Add unit test for kv. PTAL @zimulala @tiancaiamao

jackysp added some commits Jul 18, 2017

@jackysp jackysp changed the title from kv: coverage of kv to 83% to kv (test): coverage of kv to 83% Jul 18, 2017

@shenli

This comment has been minimized.

Show comment
Hide comment
@shenli

shenli Jul 18, 2017

Member

LGTM

Member

shenli commented Jul 18, 2017

LGTM

Show outdated Hide outdated kv/fault_injection_test.go
err := errors.New("foo")
cfg.SetGetError(err)
store, _, err := newStoreWithBootstrap()

This comment has been minimized.

@tiancaiamao

tiancaiamao Jul 19, 2017

Contributor

Would NewMockStorage work here?
Function newStoreWithBootstrap is time consuming.

@tiancaiamao

tiancaiamao Jul 19, 2017

Contributor

Would NewMockStorage work here?
Function newStoreWithBootstrap is time consuming.

This comment has been minimized.

@jackysp

jackysp Jul 19, 2017

Member

Ok, done.

@jackysp

jackysp Jul 19, 2017

Member

Ok, done.

@tiancaiamao

This comment has been minimized.

Show comment
Hide comment
@tiancaiamao

tiancaiamao Jul 19, 2017

Contributor

LGTM

Contributor

tiancaiamao commented Jul 19, 2017

LGTM

@hanfei1991 hanfei1991 merged commit f187f88 into master Jul 19, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@hanfei1991 hanfei1991 deleted the yusp/kv_unit_tests branch Jul 19, 2017

dbjoa added a commit to cloud-pi/tidb that referenced this pull request Jul 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment