New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: improve unit test coverage of expression.go to 82.5% #3828

Merged
merged 3 commits into from Jul 20, 2017

Conversation

Projects
None yet
4 participants
@XuHuaiyu
Contributor

XuHuaiyu commented Jul 20, 2017

@tiancaiamao

This comment has been minimized.

Show comment
Hide comment
@tiancaiamao

tiancaiamao Jul 20, 2017

Contributor

LGTM

Contributor

tiancaiamao commented Jul 20, 2017

LGTM

@hanfei1991 hanfei1991 merged commit 9ee8476 into master Jul 20, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@hanfei1991 hanfei1991 deleted the xhy/ut3 branch Jul 20, 2017

dbjoa added a commit to cloud-pi/tidb that referenced this pull request Jul 31, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment