plan: implement ExplainInfo() interface for simple operators #3883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hanfei1991 @lamxTyler @winoros PTAL |
alivxxx
reviewed
Jul 26, 2017
plan/physical_plans.go
Outdated
| @@ -530,6 +530,18 @@ const ( | |||
| CompleteAgg | |||
| ) | |||
|
|
|||
| func (at AggregationType) String() string { | |||
There was a problem hiding this comment.
Add comment for the exported function.
Also, it seems that this function is not used?
There was a problem hiding this comment.
it is used by PhysicalAggregation.ExplainInfo()
alivxxx
reviewed
Jul 26, 2017
executor/analyze_test.go
Outdated
| @@ -52,7 +52,7 @@ func (s *testSuite) TestAnalyzeTable(c *C) { | |||
| tk.MustExec("analyze table t1 index ind_a") | |||
| result = tk.MustQuery("explain select * from t1 where t1.a = 1") | |||
| rowStr = fmt.Sprintf("%s", result.Rows()) | |||
| c.Check(strings.Split(rowStr, "{")[0], Equals, "[[TableScan_4 Selection_5 cop ] [Selection_5 cop ] [TableReader_6 root ]]") | |||
| c.Check(strings.Split(rowStr, "{")[0], Equals, "[[TableScan_4 Selection_5 cop ] [Selection_5 cop eq(col(test.t1.a), const(1))] [TableReader_6 root ]]") | |||
There was a problem hiding this comment.
The Split is unnecessary now, the same with line 42, 46.
hanfei1991
reviewed
Jul 26, 2017
executor/analyze_test.go
Outdated
| @@ -52,7 +52,7 @@ func (s *testSuite) TestAnalyzeTable(c *C) { | |||
| tk.MustExec("analyze table t1 index ind_a") | |||
| result = tk.MustQuery("explain select * from t1 where t1.a = 1") | |||
| rowStr = fmt.Sprintf("%s", result.Rows()) | |||
| c.Check(strings.Split(rowStr, "{")[0], Equals, "[[TableScan_4 Selection_5 cop ] [Selection_5 cop ] [TableReader_6 root ]]") | |||
| c.Check(rowStr, Equals, "[[TableScan_4 Selection_5 cop ] [Selection_5 cop eq(col(test.t1.a), const(1))] [TableReader_6 root ]]") | |||
There was a problem hiding this comment.
I think col(blabla..), constant(blabla...) is redundant...
|
@hanfei1991 @lamxTyler PTAL again |
zz-jason
added
Priority/P1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to #3805