New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: rewrite builtin function: TIMESTAMPDIFF #4184

Merged
merged 36 commits into from Aug 22, 2017

Conversation

Projects
None yet
3 participants
@spongedu
Contributor

spongedu commented Aug 15, 2017

for #4080

@zz-jason zz-jason changed the title from expression: rewrite builtin TIMESTAMPDIFF to expression: rewrite builtin function: TIMESTAMPDIFF Aug 15, 2017

@zz-jason

This comment has been minimized.

Show comment
Hide comment
@zz-jason

zz-jason Aug 16, 2017

Member

LGTM

Member

zz-jason commented Aug 16, 2017

LGTM

@zz-jason

This comment has been minimized.

Show comment
Hide comment
@zz-jason
Member

zz-jason commented Aug 17, 2017

@XuHuaiyu PTAL.

@hanfei1991

This comment has been minimized.

Show comment
Hide comment
@hanfei1991

hanfei1991 Aug 22, 2017

Member

@spongedu Please resolve conflicts.

Member

hanfei1991 commented Aug 22, 2017

@spongedu Please resolve conflicts.

@zz-jason

This comment has been minimized.

Show comment
Hide comment
@zz-jason
Member

zz-jason commented Aug 22, 2017

@XuHuaiyu PTAL

@hanfei1991 hanfei1991 merged commit ea26ad6 into pingcap:master Aug 22, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@spongedu spongedu deleted the spongedu:rewrite_timestampdiff branch Aug 22, 2017

dbjoa added a commit to cloud-pi/tidb that referenced this pull request Aug 30, 2017

@zz-jason zz-jason referenced this pull request Sep 4, 2017

Closed

rewrite builtin functions #4080

150 of 150 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment