New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: rewrite builtin function: NOW, UTC_TIMESTAMP, UTC_DATE #4206

Merged
merged 11 commits into from Aug 22, 2017

Conversation

Projects
None yet
4 participants
@zz-jason
Member

zz-jason commented Aug 16, 2017

to #4080

@zz-jason zz-jason referenced this pull request Aug 16, 2017

Closed

rewrite builtin functions #4080

150 of 150 tasks complete
@XuHuaiyu

This comment has been minimized.

Show comment
Hide comment
@XuHuaiyu

XuHuaiyu Aug 17, 2017

Contributor

ci failed @zz-jason

Contributor

XuHuaiyu commented Aug 17, 2017

ci failed @zz-jason

@zz-jason

This comment has been minimized.

Show comment
Hide comment
@zz-jason

zz-jason Aug 17, 2017

Member

@XuHuaiyu fixed, PTAL

Member

zz-jason commented Aug 17, 2017

@XuHuaiyu fixed, PTAL

@zz-jason

This comment has been minimized.

Show comment
Hide comment
@zz-jason
Member

zz-jason commented Aug 22, 2017

@breeswish

This comment has been minimized.

Show comment
Hide comment
@breeswish

breeswish Aug 22, 2017

Member

LGTM

Member

breeswish commented Aug 22, 2017

LGTM

Show outdated Hide outdated expression/builtin_time.go Outdated
Show outdated Hide outdated expression/builtin_time.go Outdated
Show outdated Hide outdated expression/builtin_time.go Outdated
@hanfei1991

LGTM

@hanfei1991 hanfei1991 merged commit 9fb223e into master Aug 22, 2017

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
ci/circleci Your tests passed on CircleCI!
Details
license/cla Contributor License Agreement is signed.
Details

@hanfei1991 hanfei1991 deleted the timefunc_now branch Aug 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment