New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: rewrite builtin function: CURDATE, SYSDATE, YEARWEEK #4211

Merged
merged 17 commits into from Aug 24, 2017

Conversation

Projects
None yet
3 participants
@zz-jason
Member

zz-jason commented Aug 16, 2017

to #4080

@zz-jason zz-jason referenced this pull request Aug 16, 2017

Closed

rewrite builtin functions #4080

150 of 150 tasks complete
@XuHuaiyu

This comment has been minimized.

Show comment
Hide comment
@XuHuaiyu

XuHuaiyu Aug 17, 2017

Contributor

ci failed, ptal

Contributor

XuHuaiyu commented Aug 17, 2017

ci failed, ptal

@zz-jason zz-jason changed the title from expression: rewrite builtin function: CURDATE to expression: rewrite builtin function: CURDATE, SYSDATE, YEARWEEK Aug 17, 2017

@zz-jason

This comment has been minimized.

Show comment
Hide comment
@zz-jason

zz-jason Aug 17, 2017

Member

@XuHuaiyu fixed, PTAL.

Member

zz-jason commented Aug 17, 2017

@XuHuaiyu fixed, PTAL.

@zz-jason

This comment has been minimized.

Show comment
Hide comment
@zz-jason
Member

zz-jason commented Aug 22, 2017

@XuHuaiyu PTAL

@zz-jason zz-jason closed this Aug 22, 2017

@zz-jason zz-jason reopened this Aug 22, 2017

@zz-jason

This comment has been minimized.

Show comment
Hide comment
@zz-jason
Member

zz-jason commented Aug 22, 2017

fix #4245

@zz-jason

This comment has been minimized.

Show comment
Hide comment
@zz-jason
Member

zz-jason commented Aug 23, 2017

Show outdated Hide outdated expression/builtin_time.go Outdated
Show outdated Hide outdated expression/builtin_time_test.go Outdated
@zz-jason

This comment has been minimized.

Show comment
Hide comment
@zz-jason
Member

zz-jason commented Aug 24, 2017

@XuHuaiyu PTAL

@XuHuaiyu

This comment has been minimized.

Show comment
Hide comment
@XuHuaiyu

XuHuaiyu Aug 24, 2017

Contributor

LGTM

Contributor

XuHuaiyu commented Aug 24, 2017

LGTM

@breeswish

This comment has been minimized.

Show comment
Hide comment
@breeswish

breeswish Aug 24, 2017

Member

LGTM

Member

breeswish commented Aug 24, 2017

LGTM

@breeswish breeswish added status/LGT2 and removed status/LGT1 labels Aug 24, 2017

@breeswish breeswish merged commit 986fb64 into master Aug 24, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@breeswish breeswish deleted the timefunc_curdate branch Aug 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment