New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: rewrite builtin function: FIND_IN_SET #4247

Merged
merged 5 commits into from Aug 21, 2017

Conversation

Projects
None yet
4 participants
@zz-jason
Member

zz-jason commented Aug 19, 2017

to #4080

if err != nil {
return nil, errors.Trace(err)
}
bf.tp.Flen = 3

This comment has been minimized.

@XuHuaiyu

XuHuaiyu Aug 21, 2017

Contributor

why set 3 here?

@XuHuaiyu

XuHuaiyu Aug 21, 2017

Contributor

why set 3 here?

This comment has been minimized.

@zz-jason

zz-jason Aug 21, 2017

Member

copy from mysql: "Item_func_find_in_set::fix_length_and_dec()"

@zz-jason

zz-jason Aug 21, 2017

Member

copy from mysql: "Item_func_find_in_set::fix_length_and_dec()"

if s == str {
d.SetInt64(int64(i + 1))
return

This comment has been minimized.

@winkyao

winkyao Aug 21, 2017

Member

This function does not work properly if the first argument contains a comma (,) character.

@winkyao

winkyao Aug 21, 2017

Member

This function does not work properly if the first argument contains a comma (,) character.

Show outdated Hide outdated expression/integration_test.go Outdated

@zz-jason zz-jason merged commit acff4b6 into master Aug 21, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@zz-jason zz-jason deleted the strfunc_findinset branch Aug 21, 2017

@zz-jason zz-jason referenced this pull request Aug 21, 2017

Closed

rewrite builtin functions #4080

150 of 150 tasks complete

dbjoa added a commit to cloud-pi/tidb that referenced this pull request Aug 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment