New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parser,plan,ast: fix #4239, concatenates string literals which placed each other, and use first string as projection name #4252

Merged
merged 9 commits into from Aug 21, 2017

Conversation

Projects
None yet
4 participants
@winkyao
Member

winkyao commented Aug 20, 2017

winkyao added some commits Aug 20, 2017

parser,plan,ast: fix #4239, concatenates string literals which placed…
… each other, and use first string as projection name
Show outdated Hide outdated ast/expressions.go Outdated
Show outdated Hide outdated parser/lexer.go Outdated
@tiancaiamao

This comment has been minimized.

Show comment
Hide comment
@tiancaiamao

tiancaiamao Aug 21, 2017

Contributor

LGTM

Contributor

tiancaiamao commented Aug 21, 2017

LGTM

Show outdated Hide outdated parser/lexer.go Outdated

@winkyao winkyao merged commit fce5806 into master Aug 21, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@winkyao winkyao deleted the winkyao/fix_string_literal branch Aug 21, 2017

dbjoa added a commit to cloud-pi/tidb that referenced this pull request Aug 22, 2017

parser,plan,ast: fix pingcap#4239, concatenates string literals which…
… placed each other, and use first string as projection name (pingcap#4252)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment