New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression,util/types: update time Add() implementation #4267

Merged
merged 4 commits into from Sep 8, 2017

Conversation

Projects
None yet
5 participants
@tiancaiamao
Contributor

tiancaiamao commented Aug 21, 2017

Time add operation should not convert the date to Go time, calculate and convert the date back.
It's a dirty hack, ugly and error prone, so I update the implementation.
We won't bother by timezone involved in conversion any more.
Fix #3944

@tiancaiamao tiancaiamao referenced this pull request Aug 21, 2017

Closed

fix #3944 #4198

@zimulala

This comment has been minimized.

Show comment
Hide comment
@zimulala

zimulala Sep 6, 2017

Member

Please fix this conflict. @tiancaiamao

Member

zimulala commented Sep 6, 2017

Please fix this conflict. @tiancaiamao

@tiancaiamao

This comment has been minimized.

Show comment
Hide comment
@tiancaiamao

tiancaiamao Sep 6, 2017

Contributor

Done @zimulala

Contributor

tiancaiamao commented Sep 6, 2017

Done @zimulala

@zimulala

This comment has been minimized.

Show comment
Hide comment
@zimulala

zimulala Sep 8, 2017

Member

LGTM

Member

zimulala commented Sep 8, 2017

LGTM

@zimulala zimulala added status/LGT2 and removed status/LGT1 labels Sep 8, 2017

@tiancaiamao

This comment has been minimized.

Show comment
Hide comment
@tiancaiamao

tiancaiamao Sep 8, 2017

Contributor

/run-all-test

Contributor

tiancaiamao commented Sep 8, 2017

/run-all-test

@tiancaiamao tiancaiamao merged commit 1be6d24 into master Sep 8, 2017

10 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
jenkins-ci-tidb/common-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-common-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-ddl-test Jenkins job succeeded.
Details
jenkins-ci-tidb/mybatis-test Jenkins job succeeded.
Details
jenkins-ci-tidb/sqllogic-test Jenkins job succeeded.
Details
jenkins-ci-tidb/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@tiancaiamao tiancaiamao deleted the tiancaiamao/adddate branch Sep 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment