New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid 'binary BINARY' for special field type #4272

Merged
merged 2 commits into from Aug 23, 2017

Conversation

Projects
None yet
5 participants
@dantin
Contributor

dantin commented Aug 21, 2017

When parsing DML like 'ALTER TABLE t MODIFY COLUMN a binary', there will
be a node parsed as '... binary BINARY...'. That is wrong, the right result should be '... binary ...'

fix: avoid 'binary BINARY' for special field type
When parsing DML like 'ALTER TABLE t MODIFY COLUMN a binary', there will
be a node parsed as '... binary BINARY...'. That is wrong, the right result should be '... binary ...'
@CLAassistant

This comment has been minimized.

Show comment
Hide comment
@CLAassistant

CLAassistant Aug 21, 2017

CLA assistant check
All committers have signed the CLA.

CLAassistant commented Aug 21, 2017

CLA assistant check
All committers have signed the CLA.

@shenli

This comment has been minimized.

Show comment
Hide comment
@shenli

shenli Aug 21, 2017

Member

LGTM
@tiancaiamao PTAL

Member

shenli commented Aug 21, 2017

LGTM
@tiancaiamao PTAL

@zimulala

This comment has been minimized.

Show comment
Hide comment
@zimulala

zimulala Aug 23, 2017

Member

LGTM

Member

zimulala commented Aug 23, 2017

LGTM

@zimulala zimulala added status/LGT2 and removed status/LGT1 labels Aug 23, 2017

@hanfei1991 hanfei1991 merged commit 8f91590 into pingcap:master Aug 23, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

dbjoa added a commit to cloud-pi/tidb that referenced this pull request Aug 30, 2017

fix: avoid 'binary BINARY' for special field type (pingcap#4272)
When parsing DML like 'ALTER TABLE t MODIFY COLUMN a binary', there will
be a node parsed as '... binary BINARY...'. That is wrong, the right result should be '... binary ...'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment