New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plan: rewrite index join plan generation. #4274

Merged
merged 3 commits into from Aug 22, 2017

Conversation

Projects
None yet
4 participants
@hanfei1991
Member

hanfei1991 commented Aug 21, 2017

Fix a bug about correctness. In old logic, we used requried property to select index, it's not precise. Say there is an index (a,b), you want to choose index b, but there is an access condition a= 1. You may choose the wrong index (a,b) instead of b.

@zz-jason

This comment has been minimized.

Show comment
Hide comment
@zz-jason

zz-jason Aug 21, 2017

Member

LGTM

Member

zz-jason commented Aug 21, 2017

LGTM

@shenli

This comment has been minimized.

Show comment
Hide comment
@shenli

shenli Aug 21, 2017

Member

Any description about this PR? I can not find where is the bug.

Member

shenli commented Aug 21, 2017

Any description about this PR? I can not find where is the bug.

@hanfei1991 hanfei1991 merged commit 3e0bfbe into master Aug 22, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@hanfei1991 hanfei1991 deleted the hanfei/index-join branch Aug 22, 2017

dbjoa added a commit to cloud-pi/tidb that referenced this pull request Aug 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment