New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: provide SHOW PLUGINS statement with a dummy implementation #4278

Merged
merged 4 commits into from Aug 22, 2017

Conversation

Projects
None yet
4 participants
@tiancaiamao
Contributor

tiancaiamao commented Aug 22, 2017

DBName: $2.(string),
}
}
| "PLUGINS"

This comment has been minimized.

@zimulala

zimulala Aug 22, 2017

Member

Do we need to add a test in parser_test?

@zimulala

zimulala Aug 22, 2017

Member

Do we need to add a test in parser_test?

This comment has been minimized.

@tiancaiamao

tiancaiamao Aug 22, 2017

Contributor

Done.

@tiancaiamao

tiancaiamao Aug 22, 2017

Contributor

Done.

@zimulala

This comment has been minimized.

Show comment
Hide comment
@zimulala

zimulala Aug 22, 2017

Member

LGTM

Member

zimulala commented Aug 22, 2017

LGTM

@XuHuaiyu

This comment has been minimized.

Show comment
Hide comment
@XuHuaiyu

XuHuaiyu Aug 22, 2017

Contributor

LGTM

Contributor

XuHuaiyu commented Aug 22, 2017

LGTM

@XuHuaiyu XuHuaiyu added status/LGT2 and removed status/LGT1 labels Aug 22, 2017

@jackysp

LGTM

@jackysp jackysp merged commit 3f8334e into master Aug 22, 2017

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
ci/circleci Your tests passed on CircleCI!
Details
license/cla Contributor License Agreement is signed.
Details

@jackysp jackysp deleted the tiancaiamao/show-plugins branch Aug 22, 2017

dbjoa added a commit to cloud-pi/tidb that referenced this pull request Aug 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment