New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: rewrite builtin function: DAYOFWEEK, DAYOFMONTH, DAYOFYEAR #4283

Merged
merged 25 commits into from Aug 22, 2017

Conversation

Projects
None yet
3 participants
@XuHuaiyu
Contributor

XuHuaiyu commented Aug 22, 2017

@zz-jason zz-jason referenced this pull request Aug 22, 2017

Closed

rewrite builtin functions #4080

150 of 150 tasks complete
Show outdated Hide outdated expression/builtin_time.go Outdated
Show outdated Hide outdated expression/builtin_time.go Outdated

@zz-jason zz-jason changed the title from expression, plan: rewrite dayOfWeek, dayOfMonth, dayOfYear to expression: rewrite builtin function DAYOFWEEK, DAYOFMONTH, DAYOFYEAR Aug 22, 2017

@zz-jason zz-jason changed the title from expression: rewrite builtin function DAYOFWEEK, DAYOFMONTH, DAYOFYEAR to expression: rewrite builtin function: DAYOFWEEK, DAYOFMONTH, DAYOFYEAR Aug 22, 2017

@zz-jason

This comment has been minimized.

Show comment
Hide comment
@zz-jason
Member

zz-jason commented Aug 22, 2017

@jackysp jackysp added status/LGT2 and removed status/LGT1 labels Aug 22, 2017

@XuHuaiyu XuHuaiyu added the status/DNM label Aug 22, 2017

seems wrong

Merge branch 'master' of https://github.com/pingcap/tidb into xhy/dayof
Conflicts:
	expression/builtin_time_test.go

:q!

@XuHuaiyu XuHuaiyu removed the status/DNM label Aug 22, 2017

@zz-jason

LGTM

@zz-jason zz-jason merged commit 54eee2c into master Aug 22, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@zz-jason zz-jason deleted the xhy/dayof branch Aug 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment