New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: make auto analyze more conservative #4284

Merged
merged 6 commits into from Aug 24, 2017

Conversation

Projects
None yet
3 participants
@lamxTyler
Member

lamxTyler commented Aug 22, 2017

Show outdated Hide outdated executor/adapter.go Outdated
@shenli

This comment has been minimized.

Show comment
Hide comment
@shenli

shenli Aug 22, 2017

Member

We should investigate why analyze use so many memory.

Member

shenli commented Aug 22, 2017

We should investigate why analyze use so many memory.

@lamxTyler

This comment has been minimized.

Show comment
Hide comment
@lamxTyler

lamxTyler Aug 23, 2017

Member

@shenli One of the reason is that analyze will open all the sub-executors at begin, but it is not necessary, we need only open those executors when build histograms.

Member

lamxTyler commented Aug 23, 2017

@shenli One of the reason is that analyze will open all the sub-executors at begin, but it is not necessary, we need only open those executors when build histograms.

@shenli

This comment has been minimized.

Show comment
Hide comment
@shenli

shenli Aug 23, 2017

Member

LGTM
@hanfei1991 PTAL

Member

shenli commented Aug 23, 2017

LGTM
@hanfei1991 PTAL

lamxTyler added some commits Aug 23, 2017

@hanfei1991

LGTM

@hanfei1991 hanfei1991 merged commit 21a417a into master Aug 24, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@hanfei1991 hanfei1991 deleted the xhb/analyze branch Aug 24, 2017

dbjoa added a commit to cloud-pi/tidb that referenced this pull request Aug 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment