New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: fix date cmp date #4294

Merged
merged 7 commits into from Aug 24, 2017

Conversation

Projects
None yet
4 participants
@XuHuaiyu
Contributor

XuHuaiyu commented Aug 22, 2017

PTAL @hanfei1991 @zz-jason @shenli

This should fix #4069

@zz-jason

This comment has been minimized.

Show comment
Hide comment
@zz-jason

zz-jason Aug 22, 2017

Member

should we add baseDateBuiltinfunc, baseDatetimeBuiltinFunc ... and corresponding evalDate, evalDatetime ... ?

Member

zz-jason commented Aug 22, 2017

should we add baseDateBuiltinfunc, baseDatetimeBuiltinFunc ... and corresponding evalDate, evalDatetime ... ?

@shenli

This comment has been minimized.

Show comment
Hide comment
@shenli

shenli Aug 22, 2017

Member

CI failed.

Member

shenli commented Aug 22, 2017

CI failed.

@XuHuaiyu

This comment has been minimized.

Show comment
Hide comment
@XuHuaiyu

XuHuaiyu Aug 22, 2017

Contributor

@zz-jason we can take it into consideration, but it's not really necessary for this bug fix.

Contributor

XuHuaiyu commented Aug 22, 2017

@zz-jason we can take it into consideration, but it's not really necessary for this bug fix.

@XuHuaiyu

This comment has been minimized.

Show comment
Hide comment
@XuHuaiyu
Contributor

XuHuaiyu commented Aug 23, 2017

Show outdated Hide outdated expression/builtin_op.go
Show outdated Hide outdated plan/typeinfer_test.go
@XuHuaiyu

This comment has been minimized.

Show comment
Hide comment
@XuHuaiyu

XuHuaiyu Aug 23, 2017

Contributor

PTAL @zz-jason

Contributor

XuHuaiyu commented Aug 23, 2017

PTAL @zz-jason

@XuHuaiyu

This comment has been minimized.

Show comment
Hide comment
@XuHuaiyu

XuHuaiyu Aug 23, 2017

Contributor
Contributor

XuHuaiyu commented Aug 23, 2017

@XuHuaiyu

This comment has been minimized.

Show comment
Hide comment
@XuHuaiyu
Contributor

XuHuaiyu commented Aug 23, 2017

@hanfei1991

This comment has been minimized.

Show comment
Hide comment
@hanfei1991

hanfei1991 Aug 23, 2017

Member

Can we merge tpDate and tpDatetime ?

Member

hanfei1991 commented Aug 23, 2017

Can we merge tpDate and tpDatetime ?

@XuHuaiyu

This comment has been minimized.

Show comment
Hide comment
@XuHuaiyu

XuHuaiyu Aug 24, 2017

Contributor

I'm not really sure, I'll try it.

Contributor

XuHuaiyu commented Aug 24, 2017

I'm not really sure, I'll try it.

@XuHuaiyu

This comment has been minimized.

Show comment
Hide comment
@XuHuaiyu

XuHuaiyu Aug 24, 2017

Contributor
Contributor

XuHuaiyu commented Aug 24, 2017

@hanfei1991

LGTM

@hanfei1991 hanfei1991 merged commit f289c9b into master Aug 24, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@hanfei1991 hanfei1991 deleted the xhy/cast branch Aug 24, 2017

dbjoa added a commit to cloud-pi/tidb that referenced this pull request Aug 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment