New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: rewrite builtin function: MONTHNAME #4300

Merged
merged 6 commits into from Aug 23, 2017

Conversation

Projects
None yet
4 participants
@XuHuaiyu
Contributor

XuHuaiyu commented Aug 23, 2017

Show outdated Hide outdated expression/builtin_time.go Outdated
_, err = tk.Exec(`delete from t where a = monthname(123)`)
c.Assert(terror.ErrorEqual(err, types.ErrInvalidTimeFormat), IsTrue)
result = tk.MustQuery(`select monthname("2017-12-01"), monthname("0000-00-00"), monthname("0000-01-00"), monthname("0000-01-00 00:00:00")`)
result.Check(testkit.Rows("December <nil> January January"))

This comment has been minimized.

@jackysp

jackysp Aug 23, 2017

Member

Add show warnings here?

@jackysp

jackysp Aug 23, 2017

Member

Add show warnings here?

Show outdated Hide outdated expression/builtin_time.go Outdated

@zz-jason zz-jason changed the title from expression, plan: rewrite built-in func MonthName to expression: rewrite builtin function MONTHNAME Aug 23, 2017

@zz-jason zz-jason changed the title from expression: rewrite builtin function MONTHNAME to expression: rewrite builtin function: MONTHNAME Aug 23, 2017

@zz-jason zz-jason referenced this pull request Aug 23, 2017

Closed

rewrite builtin functions #4080

150 of 150 tasks complete

XuHuaiyu added some commits Aug 23, 2017

@XuHuaiyu

This comment has been minimized.

Show comment
Hide comment
@XuHuaiyu
Contributor

XuHuaiyu commented Aug 23, 2017

@jackysp

LGTM

@jackysp jackysp added status/LGT2 and removed status/LGT1 labels Aug 23, 2017

@hanfei1991 hanfei1991 merged commit f0b061c into master Aug 23, 2017

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
ci/circleci Your tests passed on CircleCI!
Details
license/cla Contributor License Agreement is signed.
Details

@hanfei1991 hanfei1991 deleted the xhy/monthname branch Aug 23, 2017

dbjoa added a commit to cloud-pi/tidb that referenced this pull request Aug 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment