New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show column comment, table auto-increment; change index default collation #4303

Merged
merged 5 commits into from Aug 26, 2017

Conversation

Projects
None yet
4 participants
@mxlxm
Contributor

mxlxm commented Aug 23, 2017

  • change index default collation from "utf8_bin" to "A".
  • show column comment. fix #4224.
  • show table auto-increment. fix #3747.
- 1. change index default collation from "utf8_bin" to "A".
- 2. show column comment. fix #4224.
- 3. show table auto-increment. fix #3747.
Show outdated Hide outdated infoschema/tables.go Outdated
@ngaut

This comment has been minimized.

Show comment
Hide comment
@ngaut

ngaut Aug 26, 2017

Member

LGTM

Member

ngaut commented Aug 26, 2017

LGTM

@ngaut

ngaut approved these changes Aug 26, 2017

@ngaut ngaut added the status/LGT2 label Aug 26, 2017

@ngaut ngaut merged commit 9367fdd into pingcap:master Aug 26, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@mxlxm mxlxm deleted the mxlxm:fix-col-comment-and-table-auto-increment branch Aug 29, 2017

dbjoa added a commit to cloud-pi/tidb that referenced this pull request Aug 30, 2017

show column comment, table auto-increment; change index default colla…
…tion (pingcap#4303)

* - 1. change index default collation from "utf8_bin" to "A".
- 2. show column comment. fix pingcap#4224.
- 3. show table auto-increment. fix pingcap#3747.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment