New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: rewrite builtin function: UTC_TIME #4304

Merged
merged 3 commits into from Aug 24, 2017

Conversation

Projects
None yet
3 participants
@spongedu
Contributor

spongedu commented Aug 23, 2017

for #4080

Show outdated Hide outdated expression/builtin_time.go Outdated
Show outdated Hide outdated expression/builtin_time.go Outdated
Show outdated Hide outdated expression/builtin_time.go Outdated
Show outdated Hide outdated expression/builtin_time.go Outdated
@zz-jason

This comment has been minimized.

Show comment
Hide comment
@zz-jason

zz-jason Aug 23, 2017

Member

add test in expression/integration_test.go

Member

zz-jason commented Aug 23, 2017

add test in expression/integration_test.go

@zz-jason zz-jason changed the title from expression: rewrite builtin UTC_TIME to expression: rewrite builtin function: UTC_TIME Aug 23, 2017

@zz-jason zz-jason referenced this pull request Aug 23, 2017

Closed

rewrite builtin functions #4080

150 of 150 tasks complete
@spongedu

This comment has been minimized.

Show comment
Hide comment
@spongedu

spongedu Aug 23, 2017

Contributor

@zz-jason The result of UTC_TIME changes over time. It seems difficult to test in expression/integration_test.go. The same as UTC_TIMESTAMP....

Contributor

spongedu commented Aug 23, 2017

@zz-jason The result of UTC_TIME changes over time. It seems difficult to test in expression/integration_test.go. The same as UTC_TIMESTAMP....

Show outdated Hide outdated expression/builtin_time.go Outdated
Show outdated Hide outdated expression/builtin_time.go Outdated
@zz-jason

This comment has been minimized.

Show comment
Hide comment
@zz-jason
Member

zz-jason commented Aug 24, 2017

@hanfei1991

LGTM

@hanfei1991 hanfei1991 merged commit 7cf42f5 into pingcap:master Aug 24, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@spongedu spongedu deleted the spongedu:rewrite_builtin_utctime branch Aug 24, 2017

dbjoa added a commit to cloud-pi/tidb that referenced this pull request Aug 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment