New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: IndexLookUpExecutor refactor #4305

Merged
merged 22 commits into from Sep 6, 2017

Conversation

Projects
None yet
5 participants
@tiancaiamao
Contributor

tiancaiamao commented Aug 23, 2017

  • When the executor close, all background goroutines should exit
  • Objects should maintain smaller inner state, high cohesion and low coupling
  • Avoid data race and make the code more reasonable
Show outdated Hide outdated executor/distsql.go
Show outdated Hide outdated executor/new_distsql.go
Show outdated Hide outdated executor/new_distsql.go

tiancaiamao added some commits Aug 24, 2017

@tiancaiamao tiancaiamao changed the title from [WIP] executor: IndexLookUpExecutor refactor to executor: IndexLookUpExecutor refactor Aug 24, 2017

Show outdated Hide outdated executor/new_distsql.go
Show outdated Hide outdated executor/new_distsql.go

tiancaiamao added some commits Aug 24, 2017

@shenli

This comment has been minimized.

Show comment
Hide comment
@shenli

shenli Aug 28, 2017

Member

LGTM

Member

shenli commented Aug 28, 2017

LGTM

@shenli

This comment has been minimized.

Show comment
Hide comment
@shenli
Member

shenli commented Aug 28, 2017

Show outdated Hide outdated executor/new_distsql.go
Show outdated Hide outdated executor/new_distsql.go
Show outdated Hide outdated executor/new_distsql.go
Show outdated Hide outdated executor/new_distsql.go
Show outdated Hide outdated executor/new_distsql.go

tiancaiamao added some commits Sep 4, 2017

Show outdated Hide outdated executor/new_distsql.go
Show outdated Hide outdated executor/new_distsql.go
Show outdated Hide outdated executor/new_distsql.go

tiancaiamao added some commits Sep 5, 2017

@tiancaiamao

This comment has been minimized.

Show comment
Hide comment
@tiancaiamao

tiancaiamao Sep 5, 2017

Contributor

PTAL @coocood

Contributor

tiancaiamao commented Sep 5, 2017

PTAL @coocood

Show outdated Hide outdated executor/new_distsql.go
Show outdated Hide outdated executor/new_distsql.go
Show outdated Hide outdated executor/new_distsql.go
Show outdated Hide outdated executor/new_distsql.go
Show outdated Hide outdated executor/new_distsql.go
Show outdated Hide outdated executor/new_distsql.go
Show outdated Hide outdated executor/new_distsql.go
Show outdated Hide outdated executor/new_distsql.go

tiancaiamao added some commits Sep 5, 2017

@shenli

This comment has been minimized.

Show comment
Hide comment
@shenli

shenli Sep 6, 2017

Member

LGTM

Member

shenli commented Sep 6, 2017

LGTM

@shenli

This comment has been minimized.

Show comment
Hide comment
@shenli

shenli Sep 6, 2017

Member

/run-all-test

Member

shenli commented Sep 6, 2017

/run-all-test

Show outdated Hide outdated executor/new_distsql.go
Show outdated Hide outdated executor/new_distsql.go
@tiancaiamao

This comment has been minimized.

Show comment
Hide comment
@tiancaiamao

tiancaiamao Sep 6, 2017

Contributor

/run-all-test

Contributor

tiancaiamao commented Sep 6, 2017

/run-all-test

@tiancaiamao

This comment has been minimized.

Show comment
Hide comment
@tiancaiamao

tiancaiamao Sep 6, 2017

Contributor

PTAL @coocood

Contributor

tiancaiamao commented Sep 6, 2017

PTAL @coocood

@coocood

This comment has been minimized.

Show comment
Hide comment
@coocood

coocood Sep 6, 2017

Member

LGTM

Member

coocood commented Sep 6, 2017

LGTM

@zimulala zimulala added status/LGT2 and removed status/LGT1 labels Sep 6, 2017

@tiancaiamao tiancaiamao merged commit dba58e9 into master Sep 6, 2017

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@tiancaiamao tiancaiamao deleted the tiancaiamao/refactor-indexlookup branch Sep 6, 2017

mccxj added a commit to mccxj/tidb that referenced this pull request Sep 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment