New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: rewrite builtin function: PERIOD_ADD, PERIOD_DIFF #4309

Merged
merged 11 commits into from Aug 29, 2017

Conversation

Projects
None yet
3 participants
@zz-jason
Member

zz-jason commented Aug 24, 2017

to #4080

@zz-jason zz-jason referenced this pull request Aug 24, 2017

Closed

rewrite builtin functions #4080

150 of 150 tasks complete
@zz-jason

This comment has been minimized.

Show comment
Hide comment
@zz-jason
Member

zz-jason commented Aug 24, 2017

@breeswish

This comment has been minimized.

Show comment
Hide comment
@breeswish

breeswish Aug 28, 2017

Member

LGTM

Member

breeswish commented Aug 28, 2017

LGTM

Show outdated Hide outdated expression/builtin_time.go
Show outdated Hide outdated expression/builtin_time.go
Show outdated Hide outdated expression/integration_test.go
@zz-jason

This comment has been minimized.

Show comment
Hide comment
@zz-jason
Member

zz-jason commented Aug 28, 2017

@XuHuaiyu PTAL

zz-jason added some commits Aug 28, 2017

@XuHuaiyu

LGTM

@zz-jason zz-jason merged commit 962b32c into master Aug 29, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@zz-jason zz-jason deleted the timefunc_period branch Aug 29, 2017

dbjoa added a commit to cloud-pi/tidb that referenced this pull request Aug 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment