New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: rewrite builtin function: DATE_FORMAT #4312

Merged
merged 6 commits into from Aug 28, 2017

Conversation

Projects
None yet
5 participants
@liangjiaxing
Contributor

liangjiaxing commented Aug 24, 2017

This fix #4230
to #4080

Show outdated Hide outdated expression/builtin_time.go
Show outdated Hide outdated expression/builtin_time.go
Show outdated Hide outdated expression/builtin_time.go
result = tk.MustQuery("SELECT DATE_FORMAT('2017-06-15', '%W %M %e %Y %r %y');")
result.Check(testkit.Rows("Thursday June 15 2017 12:00:00 AM 17"))
result = tk.MustQuery("SELECT DATE_FORMAT(151113102019.12, '%W %M %e %Y %r %y');")
result.Check(testkit.Rows("Friday November 13 2015 10:20:19 AM 15"))

This comment has been minimized.

@zz-jason

zz-jason Aug 24, 2017

Member

add test case with zero date like DATE_FORMAT('0000-00-00', '%W %M %e %Y %r %y')

@zz-jason

zz-jason Aug 24, 2017

Member

add test case with zero date like DATE_FORMAT('0000-00-00', '%W %M %e %Y %r %y')

Show outdated Hide outdated expression/builtin_time.go
Show outdated Hide outdated expression/builtin_time.go
Show outdated Hide outdated expression/builtin_time.go

@zz-jason zz-jason referenced this pull request Aug 24, 2017

Closed

rewrite builtin functions #4080

150 of 150 tasks complete
@zz-jason

This comment has been minimized.

Show comment
Hide comment
@zz-jason

zz-jason Aug 24, 2017

Member

hi, tpTime is abandon in #4294, plz update and s/tpTime/tpDatetime/

Member

zz-jason commented Aug 24, 2017

hi, tpTime is abandon in #4294, plz update and s/tpTime/tpDatetime/

@zz-jason

This comment has been minimized.

Show comment
Hide comment
@zz-jason
Member

zz-jason commented Aug 25, 2017

@jackysp

LGTM

@breeswish breeswish merged commit 499b256 into pingcap:master Aug 28, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@breeswish breeswish added status/LGT2 and removed status/LGT1 labels Aug 28, 2017

dbjoa added a commit to cloud-pi/tidb that referenced this pull request Aug 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment