New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: rewrite builtin function: DATE #4314

Merged
merged 8 commits into from Aug 24, 2017

Conversation

Projects
None yet
3 participants
@zz-jason
Member

zz-jason commented Aug 24, 2017

to #4080

@zz-jason zz-jason referenced this pull request Aug 24, 2017

Closed

rewrite builtin functions #4080

150 of 150 tasks complete
@shenli

This comment has been minimized.

Show comment
Hide comment
@shenli

shenli Aug 24, 2017

Member

LGTM

Member

shenli commented Aug 24, 2017

LGTM

@hanfei1991

This comment has been minimized.

Show comment
Hide comment
@hanfei1991

hanfei1991 Aug 24, 2017

Member

@zz-jason Fix ci please

Member

hanfei1991 commented Aug 24, 2017

@zz-jason Fix ci please

@zz-jason

This comment has been minimized.

Show comment
Hide comment
@zz-jason

zz-jason Aug 24, 2017

Member

@hanfei1991 fixed, PTAL again

Member

zz-jason commented Aug 24, 2017

@hanfei1991 fixed, PTAL again

@hanfei1991

LGTM

@hanfei1991 hanfei1991 merged commit a5acbd4 into master Aug 24, 2017

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
ci/circleci Your tests passed on CircleCI!
Details
license/cla Contributor License Agreement is signed.
Details

@hanfei1991 hanfei1991 deleted the timefunc_date branch Aug 24, 2017

dbjoa added a commit to cloud-pi/tidb that referenced this pull request Aug 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment