New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tikv: enlarge batch size #4315

Merged
merged 1 commit into from Aug 24, 2017

Conversation

Projects
None yet
4 participants
@ngaut
Member

ngaut commented Aug 24, 2017

Enlarge batch size from 128 to 256 to reduce network round trip.

@disksing

This comment has been minimized.

Show comment
Hide comment
@disksing

disksing Aug 24, 2017

Member

LGTM.

Member

disksing commented Aug 24, 2017

LGTM.

@zz-jason

This comment has been minimized.

Show comment
Hide comment
@zz-jason

zz-jason Aug 24, 2017

Member

do we have any test on how the batch size affect the cpu/mem performance ?

Member

zz-jason commented Aug 24, 2017

do we have any test on how the batch size affect the cpu/mem performance ?

@shenli

This comment has been minimized.

Show comment
Hide comment
@shenli

shenli Aug 24, 2017

Member

@zz-jason DDL worker will get 256 rows for each time. So cache 100 rows is not suitable.

Member

shenli commented Aug 24, 2017

@zz-jason DDL worker will get 256 rows for each time. So cache 100 rows is not suitable.

@shenli

This comment has been minimized.

Show comment
Hide comment
@shenli

shenli Aug 24, 2017

Member

LGTM

Member

shenli commented Aug 24, 2017

LGTM

@shenli

shenli approved these changes Aug 24, 2017

@shenli shenli merged commit c106c37 into master Aug 24, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@shenli shenli deleted the ngaut/enlarge-batch-size branch Aug 24, 2017

shenli added a commit that referenced this pull request Aug 24, 2017

dbjoa added a commit to cloud-pi/tidb that referenced this pull request Aug 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment