New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: rewrite builtin function: MAKE_SET, QUOTE #4318

Merged
merged 12 commits into from Aug 29, 2017

Conversation

Projects
None yet
4 participants
@zz-jason
Member

zz-jason commented Aug 24, 2017

to #4080

@zz-jason zz-jason referenced this pull request Aug 24, 2017

Closed

rewrite builtin functions #4080

150 of 150 tasks complete
Show outdated Hide outdated expression/builtin_string.go
Show outdated Hide outdated expression/builtin_string.go
Show outdated Hide outdated expression/builtin_string.go
@XuHuaiyu

This comment has been minimized.

Show comment
Hide comment
@XuHuaiyu
Contributor

XuHuaiyu commented Aug 28, 2017

if constant, ok := args[0].(*Constant); ok {
bits, isNull, err := constant.EvalInt(nil, sc)
if err == nil && !isNull {
for i, length := 1, len(args); i < length; i++ {

This comment has been minimized.

@jackysp

jackysp Aug 28, 2017

Member

It looks like length will be changed in the for loop, but actually not. The same with others in this pr. May be the style looks good for every one else, just comment here.

@jackysp

jackysp Aug 28, 2017

Member

It looks like length will be changed in the for loop, but actually not. The same with others in this pr. May be the style looks good for every one else, just comment here.

zz-jason added some commits Aug 29, 2017

@zz-jason

This comment has been minimized.

Show comment
Hide comment
@zz-jason
Member

zz-jason commented Aug 29, 2017

@jackysp

LGTM

@jackysp jackysp merged commit b7aa913 into master Aug 29, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@jackysp jackysp deleted the strfunc_makeset branch Aug 29, 2017

dbjoa added a commit to cloud-pi/tidb that referenced this pull request Aug 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment