New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor, plan: fix a bug occurred in `set @varname = (select a from t limit 1)` #4326

Merged
merged 10 commits into from Aug 26, 2017

Conversation

Projects
None yet
6 participants
@CodeRushing
Contributor

CodeRushing commented Aug 24, 2017

When SetStmt meet SubqueryExpr like set @varname=(select a from t), panic will occurred.
Fix #4302

@shenli

This comment has been minimized.

Show comment
Hide comment
@shenli

shenli Aug 25, 2017

Member

@CodeRushing Thanks!
Please add an unit test to cover this case.

Member

shenli commented Aug 25, 2017

@CodeRushing Thanks!
Please add an unit test to cover this case.

@CodeRushing

This comment has been minimized.

Show comment
Hide comment
@CodeRushing

CodeRushing Aug 25, 2017

Contributor

I'm sorry for that I didn't find the test file last night. I have made up the test case

Contributor

CodeRushing commented Aug 25, 2017

I'm sorry for that I didn't find the test file last night. I have made up the test case

@XuHuaiyu XuHuaiyu changed the title from fix issue #4302 to executor, plan: fix a bug occurred in `set @varname = (select a from t limit 1)` Aug 26, 2017

@XuHuaiyu

This comment has been minimized.

Show comment
Hide comment
@XuHuaiyu

XuHuaiyu Aug 26, 2017

Contributor
Contributor

XuHuaiyu commented Aug 26, 2017

@hanfei1991

LGTM

@hanfei1991 hanfei1991 merged commit 45a9515 into pingcap:master Aug 26, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

dbjoa added a commit to cloud-pi/tidb that referenced this pull request Aug 30, 2017

executor, plan: fix a bug occurred in `set @varname = (select a from …
…t limit 1)` (pingcap#4326)

* fix infoschema not support unsigned

* change the comment of FieldType's InfoSchemaStr for specification

* fix issue pingcap#4302

* use mockPlan instend of process subquery directly

* add test case for issue pingcap#4302
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment