New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: rewrite builtin function TIMESTAMP #4327

Merged
merged 5 commits into from Aug 27, 2017

Conversation

Projects
None yet
3 participants
@spongedu
Contributor

spongedu commented Aug 25, 2017

for #4080

Show outdated Hide outdated expression/builtin_time.go Outdated
Show outdated Hide outdated expression/builtin_time.go Outdated
Show outdated Hide outdated expression/builtin_time.go Outdated
Show outdated Hide outdated expression/builtin_time.go Outdated
Show outdated Hide outdated expression/builtin_time.go Outdated
Show outdated Hide outdated expression/builtin_time.go Outdated
Show outdated Hide outdated expression/builtin_time.go Outdated
Show outdated Hide outdated expression/builtin_time.go Outdated
Show outdated Hide outdated expression/integration_test.go Outdated
@zz-jason

This comment has been minimized.

Show comment
Hide comment
@zz-jason
Member

zz-jason commented Aug 26, 2017

@XuHuaiyu PTAL.

@zz-jason zz-jason referenced this pull request Aug 26, 2017

Closed

rewrite builtin functions #4080

150 of 150 tasks complete
Show outdated Hide outdated expression/builtin_time.go Outdated
@shenli

This comment has been minimized.

Show comment
Hide comment
@shenli

shenli Aug 27, 2017

Member

LGTM

Member

shenli commented Aug 27, 2017

LGTM

@shenli shenli added status/LGT2 and removed status/LGT1 labels Aug 27, 2017

@shenli

shenli approved these changes Aug 27, 2017

@shenli shenli merged commit 43bc0a2 into pingcap:master Aug 27, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@spongedu spongedu deleted the spongedu:rewrite_builtin_timestamp branch Aug 27, 2017

dbjoa added a commit to cloud-pi/tidb that referenced this pull request Aug 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment