New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: rewrite builtin function: RLIKE #4331

Merged
merged 6 commits into from Aug 28, 2017

Conversation

Projects
None yet
3 participants
@zz-jason
Member

zz-jason commented Aug 26, 2017

to #4080
fix #4337

@zz-jason zz-jason referenced this pull request Aug 26, 2017

Closed

rewrite builtin functions #4080

150 of 150 tasks complete
@shenli

This comment has been minimized.

Show comment
Hide comment
@shenli

shenli Aug 27, 2017

Member

LGTM

Member

shenli commented Aug 27, 2017

LGTM

@jackysp

This comment has been minimized.

Show comment
Hide comment
@jackysp

jackysp Aug 28, 2017

Member

Please add some integration test.

Member

jackysp commented Aug 28, 2017

Please add some integration test.

@zz-jason

This comment has been minimized.

Show comment
Hide comment
@zz-jason
Member

zz-jason commented Aug 28, 2017

@jackysp PTAL

@jackysp

LGTM

@jackysp jackysp merged commit 8d66f5b into master Aug 28, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@jackysp jackysp deleted the likefunc_rlike branch Aug 28, 2017

dbjoa added a commit to cloud-pi/tidb that referenced this pull request Aug 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment