New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: index join key should be encoded comparable. #4363

merged 4 commits into from Aug 29, 2017
Jump to file or symbol
Failed to load files and symbols.
+2 −2
Diff settings


Just for now

@@ -121,7 +121,7 @@ func (e *IndexLookUpJoin) Next() (Row, error) {
joinDatums = append(joinDatums, innerDatum)
joinOuterEncodeKey, err := codec.EncodeValue(nil, joinDatums...)
joinOuterEncodeKey, err := codec.EncodeKey(nil, joinDatums...)
if err != nil {
return nil, errors.Trace(err)
@@ -187,7 +187,7 @@ func (e *IndexLookUpJoin) doJoin() error {
datum, _ := col.Eval(innerRow)
joinDatums = append(joinDatums, datum)
joinKey, err := codec.EncodeValue(nil, joinDatums...)
joinKey, err := codec.EncodeKey(nil, joinDatums...)
if err != nil {
return errors.Trace(err)
ProTip! Use n and p to navigate between commits in a pull request.