New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: builtin function OCT() handle binary value mistakenly. #4369

Merged
merged 5 commits into from Aug 30, 2017

Conversation

Projects
None yet
3 participants
@winkyao
Member

winkyao commented Aug 29, 2017

@zz-jason

This comment has been minimized.

Show comment
Hide comment
@zz-jason

zz-jason Aug 29, 2017

Member

LGTM

Member

zz-jason commented Aug 29, 2017

LGTM

@zz-jason zz-jason changed the title from expression: fix #4356, builtin function OCT() handle binary value mistakenly. to expression: builtin function OCT() handle binary value mistakenly. Aug 29, 2017

@XuHuaiyu

LGTM

@XuHuaiyu XuHuaiyu added status/LGT2 and removed status/LGT1 labels Aug 30, 2017

@winkyao winkyao merged commit 7f6d60a into master Aug 30, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@winkyao winkyao deleted the winkyao/fix_oct branch Aug 30, 2017

dbjoa added a commit to cloud-pi/tidb that referenced this pull request Aug 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment