New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression, types: add NumberToDuration function, use it when cast int as duration, and check whether date is zero and returns error. partically fix #4340 #4387

Merged
merged 9 commits into from Aug 31, 2017

Conversation

Projects
None yet
4 participants
@winkyao
Member

winkyao commented Aug 31, 2017

winkyao added some commits Aug 31, 2017

expression, types: add NumberToDuration function, use it when cast in…
…t as duration, and check whether date is zero and returns error. partically fix #4340
@winkyao

This comment has been minimized.

Show comment
Hide comment
@winkyao
Member

winkyao commented Aug 31, 2017

@winkyao winkyao added the status/LGT1 label Aug 31, 2017

Show outdated Hide outdated expression/builtin_cast.go
Show outdated Hide outdated util/types/convert.go
Show outdated Hide outdated util/types/convert.go
Show outdated Hide outdated util/types/convert.go
}
// MaxMySQLTime returns Time with maximum mysql time type.
func MaxMySQLTime(neg bool, fsp int) Time {

This comment has been minimized.

@XuHuaiyu

XuHuaiyu Aug 31, 2017

Contributor

MaxMySQLTime is 838:59:59 but not 838:59:59.999999?

@XuHuaiyu

XuHuaiyu Aug 31, 2017

Contributor

MaxMySQLTime is 838:59:59 but not 838:59:59.999999?

This comment has been minimized.

@winkyao

winkyao Aug 31, 2017

Member

port from MySQL. :)

see set_max_time

@winkyao

winkyao Aug 31, 2017

Member

port from MySQL. :)

see set_max_time

@winkyao

This comment has been minimized.

Show comment
Hide comment
@winkyao
Member

winkyao commented Aug 31, 2017

@XuHuaiyu PTAL

@winkyao winkyao closed this Aug 31, 2017

@winkyao winkyao reopened this Aug 31, 2017

@winkyao

This comment has been minimized.

Show comment
Hide comment
@winkyao

winkyao Aug 31, 2017

Member

@XuHuaiyu Done, PTAL

Member

winkyao commented Aug 31, 2017

@XuHuaiyu Done, PTAL

@XuHuaiyu

This comment has been minimized.

Show comment
Hide comment
@XuHuaiyu

XuHuaiyu Aug 31, 2017

Contributor

rest LGTM

Contributor

XuHuaiyu commented Aug 31, 2017

rest LGTM

@XuHuaiyu

LGTM

@XuHuaiyu XuHuaiyu added status/LGT2 and removed status/LGT1 labels Aug 31, 2017

@hanfei1991 hanfei1991 merged commit e6985a2 into master Aug 31, 2017

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
ci/circleci Your tests passed on CircleCI!
Details
license/cla Contributor License Agreement is signed.
Details

@hanfei1991 hanfei1991 deleted the winkyao/parseduration_return_is_null branch Aug 31, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment