New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression, plan: rewrite builtin func found_rows, database, current_user, user, connection_id, version #4395

Merged
merged 10 commits into from Sep 2, 2017

Conversation

Projects
None yet
3 participants
@XuHuaiyu
Contributor

XuHuaiyu commented Aug 31, 2017

@zz-jason zz-jason referenced this pull request Aug 31, 2017

Closed

rewrite builtin functions #4080

150 of 150 tasks complete
@zz-jason

This comment has been minimized.

Show comment
Hide comment
@zz-jason

zz-jason Sep 1, 2017

Member

@XuHuaiyu plz resolve conflicts.
@breeswish PTAL.

Member

zz-jason commented Sep 1, 2017

@XuHuaiyu plz resolve conflicts.
@breeswish PTAL.

Show outdated Hide outdated expression/builtin_info.go
Show outdated Hide outdated expression/builtin_info.go
Show outdated Hide outdated expression/builtin_info.go
Show outdated Hide outdated expression/builtin_info.go
Show outdated Hide outdated expression/builtin_info.go

XuHuaiyu added some commits Sep 1, 2017

@XuHuaiyu

This comment has been minimized.

Show comment
Hide comment
@XuHuaiyu
Contributor

XuHuaiyu commented Sep 1, 2017

@zz-jason

This comment has been minimized.

Show comment
Hide comment
@zz-jason

zz-jason Sep 1, 2017

Member

LGTM

Member

zz-jason commented Sep 1, 2017

LGTM

@zz-jason zz-jason added the status/LGT1 label Sep 1, 2017

@winkyao

This comment has been minimized.

Show comment
Hide comment
@winkyao

winkyao Sep 1, 2017

Member

please fix ci. @XuHuaiyu

Member

winkyao commented Sep 1, 2017

please fix ci. @XuHuaiyu

@zz-jason zz-jason merged commit de86e7d into master Sep 2, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@zz-jason zz-jason deleted the xhy/sigs branch Sep 2, 2017

mccxj added a commit to mccxj/tidb that referenced this pull request Sep 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment