New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: rewrite builtin function MAKETIME #4396

Merged
merged 11 commits into from Sep 13, 2017

Conversation

Projects
None yet
7 participants
@spongedu
Contributor

spongedu commented Aug 31, 2017

for #4080

spongedu added some commits Aug 31, 2017

{[]interface{}{837, 59, 59.1}, "837:59:59.1"},
{[]interface{}{838, 59, 59.1}, "838:59:59.0"},
{[]interface{}{-838, 59, 59.1}, "-838:59:59.0"},
{[]interface{}{837, 59, 59.1}, "837:59:59.100000"},

This comment has been minimized.

@zz-jason

zz-jason Aug 31, 2017

Member

in mysql:

MySQL > select maketime(837, 59, 59.1);
-------------------------+
| maketime(837, 59, 59.1) |
+-------------------------+
| 837:59:59.1             |
+-------------------------+
1 row in set (0.00 sec)
@zz-jason

zz-jason Aug 31, 2017

Member

in mysql:

MySQL > select maketime(837, 59, 59.1);
-------------------------+
| maketime(837, 59, 59.1) |
+-------------------------+
| 837:59:59.1             |
+-------------------------+
1 row in set (0.00 sec)

This comment has been minimized.

@spongedu

spongedu Sep 1, 2017

Contributor

Yep. You can see my integration tests.There's a similar case and the result is correct. Decimals goes wrong here because 'datumsToConstants' don't correctly set constants's decimal(all are set -1, which is not as expected). So here the tests equal to creating a table with a double column, and use it as the third parameter in MAKETIME

@spongedu

spongedu Sep 1, 2017

Contributor

Yep. You can see my integration tests.There's a similar case and the result is correct. Decimals goes wrong here because 'datumsToConstants' don't correctly set constants's decimal(all are set -1, which is not as expected). So here the tests equal to creating a table with a double column, and use it as the third parameter in MAKETIME

This comment has been minimized.

@spongedu
@spongedu

spongedu Sep 1, 2017

Contributor

@zz-jason zz-jason referenced this pull request Sep 1, 2017

Closed

rewrite builtin functions #4080

150 of 150 tasks complete
@sre-bot

This comment has been minimized.

Show comment
Hide comment
@sre-bot

sre-bot Sep 2, 2017

Hi contributor, thanks for your PR.

This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically.

sre-bot commented Sep 2, 2017

Hi contributor, thanks for your PR.

This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically.

@shenli

This comment has been minimized.

Show comment
Hide comment
@shenli

shenli Sep 2, 2017

Member

@spongedu Please fix CI.

Member

shenli commented Sep 2, 2017

@spongedu Please fix CI.

@iamxy

This comment has been minimized.

Show comment
Hide comment
@iamxy

iamxy Sep 4, 2017

Member

/ok-to-test

Member

iamxy commented Sep 4, 2017

/ok-to-test

@zz-jason

This comment has been minimized.

Show comment
Hide comment
@zz-jason

zz-jason Sep 5, 2017

Member

@spongedu any updates ?

Member

zz-jason commented Sep 5, 2017

@spongedu any updates ?

@spongedu

This comment has been minimized.

Show comment
Hide comment
@spongedu

spongedu Sep 9, 2017

Contributor

Went out for a few days so AFK for a while. PTAL @zz-jason

Contributor

spongedu commented Sep 9, 2017

Went out for a few days so AFK for a while. PTAL @zz-jason

@spongedu

This comment has been minimized.

Show comment
Hide comment
@spongedu

spongedu Sep 9, 2017

Contributor

done @zz-jason

Contributor

spongedu commented Sep 9, 2017

done @zz-jason

Show outdated Hide outdated expression/builtin_time.go

@XuHuaiyu XuHuaiyu added status/LGT2 and removed status/LGT1 labels Sep 13, 2017

@XuHuaiyu

LGTM

@XuHuaiyu

This comment has been minimized.

Show comment
Hide comment
@XuHuaiyu

XuHuaiyu Sep 13, 2017

Contributor

/run-all-test

Contributor

XuHuaiyu commented Sep 13, 2017

/run-all-test

@hanfei1991 hanfei1991 merged commit a2723bf into pingcap:master Sep 13, 2017

10 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
jenkins-ci-tidb/common-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-common-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-ddl-test Jenkins job succeeded.
Details
jenkins-ci-tidb/mybatis-test Jenkins job succeeded.
Details
jenkins-ci-tidb/sqllogic-test Jenkins job succeeded.
Details
jenkins-ci-tidb/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@spongedu spongedu deleted the spongedu:rewrite_maketime branch Sep 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment