New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: rewrite builtin function: GET_FORMAT #4422

Merged
merged 3 commits into from Sep 5, 2017

Conversation

Projects
None yet
5 participants
@XuHuaiyu
Contributor

XuHuaiyu commented Sep 4, 2017

to #4080
PTAL @zz-jason @breewish @jackysp

@zz-jason zz-jason referenced this pull request Sep 4, 2017

Closed

rewrite builtin functions #4080

150 of 150 tasks complete

@zz-jason zz-jason added the status/LGT1 label Sep 5, 2017

@XuHuaiyu

This comment has been minimized.

Show comment
Hide comment
@XuHuaiyu
Contributor

XuHuaiyu commented Sep 5, 2017

@zz-jason zz-jason changed the title from expression, plan: rewrite builtin func get_format to expression: rewrite builtin function: GET_FORMAT Sep 5, 2017

@shenli

This comment has been minimized.

Show comment
Hide comment
@shenli

shenli Sep 5, 2017

Member

LGTM

Member

shenli commented Sep 5, 2017

LGTM

@shenli

shenli approved these changes Sep 5, 2017

@winoros

This comment has been minimized.

Show comment
Hide comment
@winoros

winoros Sep 5, 2017

Member

/run-integration-test

Member

winoros commented Sep 5, 2017

/run-integration-test

@zz-jason

This comment has been minimized.

Show comment
Hide comment
@zz-jason

zz-jason Sep 5, 2017

Member

/run-base-test

Member

zz-jason commented Sep 5, 2017

/run-base-test

@XuHuaiyu XuHuaiyu added status/LGT2 and removed status/LGT1 labels Sep 5, 2017

@hanfei1991 hanfei1991 merged commit 5f00460 into master Sep 5, 2017

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@hanfei1991 hanfei1991 deleted the xhy/getformat branch Sep 5, 2017

mccxj added a commit to mccxj/tidb that referenced this pull request Sep 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment