New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: Fix DEFAULT output in SHOW CREATE TABLE #4427

Merged
merged 2 commits into from Sep 5, 2017

Conversation

Projects
None yet
3 participants
@breeswish
Member

breeswish commented Sep 4, 2017

Fix #4426
Fix #4425

@winkyao PTAL

breeswish added some commits Sep 4, 2017

@winkyao

This comment has been minimized.

Show comment
Hide comment
@winkyao
Member

winkyao commented Sep 4, 2017

@shenli PTAL

if col.Tp == mysql.TypeBit {
bytes := make([]byte, 8)
copy(bytes[8-len(defaultValStr):8], []byte(defaultValStr))
intValue := binary.BigEndian.Uint64(bytes)

This comment has been minimized.

@breeswish

breeswish Sep 4, 2017

Member

This piece of code can be reorganized better in #4415, in which utility functions have been provided already for this kind of scenario. As a hot fix for master branch, let's keep as it is.

@breeswish

breeswish Sep 4, 2017

Member

This piece of code can be reorganized better in #4415, in which utility functions have been provided already for this kind of scenario. As a hot fix for master branch, let's keep as it is.

@coocood

This comment has been minimized.

Show comment
Hide comment
@coocood

coocood Sep 5, 2017

Member

LGTM

Member

coocood commented Sep 5, 2017

LGTM

@coocood

coocood approved these changes Sep 5, 2017

@coocood coocood merged commit bc0efef into master Sep 5, 2017

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@coocood coocood deleted the wenxuan/fix-show-table-bit-field branch Sep 5, 2017

mccxj added a commit to mccxj/tidb that referenced this pull request Sep 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment