New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: rewrite builtin function: EXPORT_SET #4434

Merged
merged 14 commits into from Sep 7, 2017

Conversation

Projects
None yet
3 participants
@zz-jason
Member

zz-jason commented Sep 5, 2017

to #4080

@zz-jason zz-jason referenced this pull request Sep 5, 2017

Closed

rewrite builtin functions #4080

150 of 150 tasks complete
@zz-jason

This comment has been minimized.

Show comment
Hide comment
@zz-jason
Member

zz-jason commented Sep 6, 2017

@jackysp

This comment has been minimized.

Show comment
Hide comment
@jackysp

jackysp Sep 6, 2017

Member

LGTM

Member

jackysp commented Sep 6, 2017

LGTM

@zz-jason

This comment has been minimized.

Show comment
Hide comment
@zz-jason
Member

zz-jason commented Sep 7, 2017

@XuHuaiyu PTAL

Show outdated Hide outdated expression/builtin_string.go
Show outdated Hide outdated expression/builtin_string.go
@zz-jason

This comment has been minimized.

Show comment
Hide comment
@zz-jason
Member

zz-jason commented Sep 7, 2017

@XuHuaiyu PTAL

@XuHuaiyu

This comment has been minimized.

Show comment
Hide comment
@XuHuaiyu

XuHuaiyu Sep 7, 2017

Contributor

/run-all-test

Contributor

XuHuaiyu commented Sep 7, 2017

/run-all-test

@XuHuaiyu

LGTM

@XuHuaiyu XuHuaiyu merged commit 2736812 into master Sep 7, 2017

10 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
jenkins-ci-tidb/common-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-common-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-ddl-test Jenkins job succeeded.
Details
jenkins-ci-tidb/mybatis-test Jenkins job succeeded.
Details
jenkins-ci-tidb/sqllogic-test Jenkins job succeeded.
Details
jenkins-ci-tidb/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@XuHuaiyu XuHuaiyu deleted the zz-jason/expression/string/export_set branch Sep 7, 2017

mccxj added a commit to mccxj/tidb that referenced this pull request Sep 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment