New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plan: let "allocID()" return int to make performance happy #4441

Merged
merged 11 commits into from Sep 6, 2017

Conversation

Projects
None yet
5 participants
@zz-jason
Member

zz-jason commented Sep 5, 2017

fix #4440

Show outdated Hide outdated plan/plan.go
@@ -1345,7 +1345,7 @@ func (b *planBuilder) buildSemiApply(outerPlan, innerPlan LogicalPlan, condition
join := b.buildSemiJoin(outerPlan, innerPlan, condition, asScalar, not)
ap := &LogicalApply{LogicalJoin: *join}

This comment has been minimized.

@winoros

winoros Sep 6, 2017

Member

Here can call init() directly?

@winoros

winoros Sep 6, 2017

Member

Here can call init() directly?

@zz-jason zz-jason added the status/WIP label Sep 6, 2017

zz-jason added some commits Sep 6, 2017

Show outdated Hide outdated expression/constant_test.go
Show outdated Hide outdated plan/plan.go

@zz-jason zz-jason removed the status/WIP label Sep 6, 2017

@hanfei1991

This comment has been minimized.

Show comment
Hide comment
@hanfei1991

hanfei1991 Sep 6, 2017

Member

LGTM

Member

hanfei1991 commented Sep 6, 2017

LGTM

@zz-jason

This comment has been minimized.

Show comment
Hide comment
@zz-jason

zz-jason Sep 6, 2017

Member

/run-all-test

Member

zz-jason commented Sep 6, 2017

/run-all-test

@zz-jason

This comment has been minimized.

Show comment
Hide comment
@zz-jason
Member

zz-jason commented Sep 6, 2017

@winoros

winoros approved these changes Sep 6, 2017

LGTM

@XuHuaiyu

Well done~
LGTM

@winoros

This comment has been minimized.

Show comment
Hide comment
@winoros

winoros Sep 6, 2017

Member

/run-all-test

Member

winoros commented Sep 6, 2017

/run-all-test

@XuHuaiyu XuHuaiyu merged commit ffa8405 into master Sep 6, 2017

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@XuHuaiyu XuHuaiyu deleted the zz-jason/plan/performance/4440 branch Sep 6, 2017

mccxj added a commit to mccxj/tidb that referenced this pull request Sep 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment