New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plan: fix a but about limit pushdown #4449

Merged
merged 4 commits into from Sep 6, 2017

Conversation

Projects
None yet
5 participants
@hanfei1991
Member

hanfei1991 commented Sep 6, 2017

When the read way is double read and the data is scanned by order, limit shouldn't be pushed to table side.

Show outdated Hide outdated plan/task.go

hanfei1991 added some commits Sep 6, 2017

@winoros winoros added the status/LGT1 label Sep 6, 2017

@winkyao winkyao added the priority/P1 label Sep 6, 2017

@lamxTyler

LGTM

@lamxTyler

This comment has been minimized.

Show comment
Hide comment
@lamxTyler

lamxTyler Sep 6, 2017

Member

/run-all-test

Member

lamxTyler commented Sep 6, 2017

/run-all-test

@zimulala zimulala added status/LGT2 and removed status/LGT1 labels Sep 6, 2017

@winoros winoros merged commit 7fc07a4 into master Sep 6, 2017

10 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
jenkins-ci-tidb/common-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-common-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-ddl-test Jenkins job succeeded.
Details
jenkins-ci-tidb/mybatis-test Jenkins job succeeded.
Details
jenkins-ci-tidb/sqllogic-test Jenkins job succeeded.
Details
jenkins-ci-tidb/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@winoros winoros deleted the hanfei/limit branch Sep 6, 2017

mccxj added a commit to mccxj/tidb that referenced this pull request Sep 7, 2017

hanfei1991 added a commit that referenced this pull request Sep 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment