New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: hide secure information in SHOW PROCESSLIST #4451

Merged
merged 9 commits into from Sep 12, 2017

Conversation

Projects
None yet
4 participants
@tiancaiamao
Contributor

tiancaiamao commented Sep 6, 2017

show processlist should not display something like password.

@zimulala @coocood @shenli

Show outdated Hide outdated ast/ast.go
@shenli

This comment has been minimized.

Show comment
Hide comment
@shenli

shenli Sep 8, 2017

Member

@tiancaiamao Any update?

Member

shenli commented Sep 8, 2017

@tiancaiamao Any update?

@tiancaiamao

This comment has been minimized.

Show comment
Hide comment
@tiancaiamao
Contributor

tiancaiamao commented Sep 11, 2017

Show outdated Hide outdated ast/misc.go
@coocood

This comment has been minimized.

Show comment
Hide comment
@coocood

coocood Sep 11, 2017

Member

Please add test.

Member

coocood commented Sep 11, 2017

Please add test.

@coocood

This comment has been minimized.

Show comment
Hide comment
@coocood

coocood Sep 11, 2017

Member

LGTM

Member

coocood commented Sep 11, 2017

LGTM

@tiancaiamao

This comment has been minimized.

Show comment
Hide comment
@tiancaiamao

tiancaiamao Sep 12, 2017

Contributor

/run-all-test

Contributor

tiancaiamao commented Sep 12, 2017

/run-all-test

@tiancaiamao

This comment has been minimized.

Show comment
Hide comment
@tiancaiamao
Contributor

tiancaiamao commented Sep 12, 2017

@zimulala

This comment has been minimized.

Show comment
Hide comment
@zimulala

zimulala Sep 12, 2017

Member

LGTM

Member

zimulala commented Sep 12, 2017

LGTM

@zimulala zimulala removed the status/LGT1 label Sep 12, 2017

@tiancaiamao tiancaiamao merged commit 3428d80 into master Sep 12, 2017

3 of 4 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
ci/circleci Your tests passed on CircleCI!
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@tiancaiamao tiancaiamao deleted the tiancaiamao/processlist-password branch Sep 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment