New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gc: use tmp session in gc_worker instead of global singleton. #4453

Merged
merged 4 commits into from Sep 7, 2017

Conversation

Projects
None yet
3 participants
@hicqu
Contributor

hicqu commented Sep 6, 2017

Previously multi threads in GCWorker use one Session, which may cause we can't get a good transaction when we execute SQLs. Now we make them use tmp sessions to resolve that.

@hicqu hicqu requested review from tiancaiamao, shenli and hanfei1991 Sep 6, 2017

@hicqu

This comment has been minimized.

Show comment
Hide comment
@hicqu

hicqu Sep 7, 2017

Contributor

@shenli @tiancaiamao @hanfei1991 , PTAL, thanks.

Contributor

hicqu commented Sep 7, 2017

@shenli @tiancaiamao @hanfei1991 , PTAL, thanks.

@coocood

This comment has been minimized.

Show comment
Hide comment
@coocood

coocood Sep 7, 2017

Member

LGTM

Member

coocood commented Sep 7, 2017

LGTM

@hanfei1991

LGTM

@hanfei1991 hanfei1991 merged commit e442273 into master Sep 7, 2017

3 of 4 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
ci/circleci Your tests passed on CircleCI!
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@hanfei1991 hanfei1991 deleted the qupeng/del-range-fix branch Sep 7, 2017

mccxj added a commit to mccxj/tidb that referenced this pull request Sep 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment