New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: Add the txn entry limit #4458

Merged
merged 3 commits into from Sep 7, 2017

Conversation

Projects
None yet
3 participants
@zimulala
Member

zimulala commented Sep 7, 2017

It will exceed the transaction limit when the table schema info is too large.
Here if this job is large we need to cancel this job.

@zimulala

This comment has been minimized.

Show comment
Hide comment
@zimulala
Member

zimulala commented Sep 7, 2017

if kv.ErrEntryTooLarge.Equal(err) {
log.Warnf("[ddl] update DDL job %v failed %v", job, errors.ErrorStack(err))
// Reduce this txn entry size.
job.BinlogInfo.Clean()

This comment has been minimized.

@winkyao

winkyao Sep 7, 2017

Member

why need to clean binloginfo here?

@winkyao

winkyao Sep 7, 2017

Member

why need to clean binloginfo here?

This comment has been minimized.

@zimulala

zimulala Sep 7, 2017

Member

Because binloginfo's tableInfo is large. If doesn't clean it, we can't commit this job. @winkyao

@zimulala

zimulala Sep 7, 2017

Member

Because binloginfo's tableInfo is large. If doesn't clean it, we can't commit this job. @winkyao

This comment has been minimized.

@winkyao

winkyao Sep 7, 2017

Member

got it.

@winkyao

winkyao Sep 7, 2017

Member

got it.

Show outdated Hide outdated ddl/ddl_worker.go

@zimulala zimulala added the status/LGT1 label Sep 7, 2017

@zimulala

This comment has been minimized.

Show comment
Hide comment
@zimulala
Member

zimulala commented Sep 7, 2017

PTAL @coocood

@zimulala zimulala added the priority/P3 label Sep 7, 2017

@coocood

This comment has been minimized.

Show comment
Hide comment
@coocood

coocood Sep 7, 2017

Member

LGTM

Member

coocood commented Sep 7, 2017

LGTM

@coocood

coocood approved these changes Sep 7, 2017

@coocood

This comment has been minimized.

Show comment
Hide comment
@coocood

coocood Sep 7, 2017

Member

/run-all-test

Member

coocood commented Sep 7, 2017

/run-all-test

@coocood coocood merged commit 3e125a4 into master Sep 7, 2017

3 of 4 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
ci/circleci Your tests passed on CircleCI!
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@coocood coocood deleted the zimuxia/ddl-txn-limit branch Sep 7, 2017

lamxTyler added a commit that referenced this pull request Sep 7, 2017

mccxj added a commit to mccxj/tidb that referenced this pull request Sep 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment