New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: rewrite builtin function: CONVERT_TZ #4463

Merged
merged 15 commits into from Sep 11, 2017

Conversation

Projects
None yet
3 participants
@zz-jason
Member

zz-jason commented Sep 7, 2017

to #4080

@zz-jason zz-jason referenced this pull request Sep 7, 2017

Closed

rewrite builtin functions #4080

150 of 150 tasks complete
@zz-jason

This comment has been minimized.

Show comment
Hide comment
@zz-jason
Member

zz-jason commented Sep 8, 2017

case tpReal, tpDecimal:
decimal = arg.GetType().Decimal
case tpString:
str, isNull, err := dt.EvalString(nil, ctx.GetSessionVars().StmtCtx)

This comment has been minimized.

@jackysp

jackysp Sep 8, 2017

Member

Is it safe to ignore this error?

@jackysp

jackysp Sep 8, 2017

Member

Is it safe to ignore this error?

This comment has been minimized.

@zz-jason

zz-jason Sep 8, 2017

Member

yes. this happens during type inference, here we only need to calculate the Decimal for return type. This parameter will be calculated again during the execution stage, if any error detected, it will be returned.

@zz-jason

zz-jason Sep 8, 2017

Member

yes. this happens during type inference, here we only need to calculate the Decimal for return type. This parameter will be calculated again during the execution stage, if any error detected, it will be returned.

@zz-jason

This comment has been minimized.

Show comment
Hide comment
@zz-jason
Member

zz-jason commented Sep 11, 2017

Show outdated Hide outdated expression/builtin_time.go
Show outdated Hide outdated expression/builtin_time.go

zz-jason added some commits Sep 11, 2017

@zz-jason

This comment has been minimized.

Show comment
Hide comment
@zz-jason

zz-jason Sep 11, 2017

Member

@XuHuaiyu PTAL again.

Member

zz-jason commented Sep 11, 2017

@XuHuaiyu PTAL again.

@XuHuaiyu XuHuaiyu merged commit d4bfcf0 into master Sep 11, 2017

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@XuHuaiyu XuHuaiyu deleted the zz-jason/expression/time/convert_tz branch Sep 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment