New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

distsql: prework for analyze pushdown #4471

Merged
merged 7 commits into from Sep 8, 2017

Conversation

Projects
None yet
4 participants
@lamxTyler
Member

lamxTyler commented Sep 7, 2017

This is part of pre work for analyzing push down. This PR implements a distsql request for analyze, and a special NextRaw for the use of analyze.
PTAL @coocood @hanfei1991 @winoros

@coocood

This comment has been minimized.

Show comment
Hide comment
@coocood

coocood Sep 7, 2017

Member

Have you considered to reuse the old iterator by modifying it?

Member

coocood commented Sep 7, 2017

Have you considered to reuse the old iterator by modifying it?

@coocood

This comment has been minimized.

Show comment
Hide comment
@coocood

coocood Sep 7, 2017

Member

We can add NextRaw on SelectResult, and change resultWithErr.result type to []byte.
unmarshal to PartialResult only on Next method, return the raw []byte on NextRaw.

Member

coocood commented Sep 7, 2017

We can add NextRaw on SelectResult, and change resultWithErr.result type to []byte.
unmarshal to PartialResult only on Next method, return the raw []byte on NextRaw.

lamxTyler added some commits Sep 8, 2017

@lamxTyler lamxTyler changed the title from distsql: implement a special coprocessor iterator for analyze to distsql: prework for analyze pushdown Sep 8, 2017

@coocood

This comment has been minimized.

Show comment
Hide comment
@coocood

coocood Sep 8, 2017

Member

LGTM

Member

coocood commented Sep 8, 2017

LGTM

@zimulala

This comment has been minimized.

Show comment
Hide comment
@zimulala

zimulala Sep 8, 2017

Member

LGTM

Member

zimulala commented Sep 8, 2017

LGTM

@zimulala zimulala added status/LGT2 and removed status/LGT1 labels Sep 8, 2017

@zimulala

This comment has been minimized.

Show comment
Hide comment
@zimulala

zimulala Sep 8, 2017

Member

/run-all-test

Member

zimulala commented Sep 8, 2017

/run-all-test

@lamxTyler

This comment has been minimized.

Show comment
Hide comment
@lamxTyler

lamxTyler Sep 8, 2017

Member

@zimulala PTAL again, Thanks.

Member

lamxTyler commented Sep 8, 2017

@zimulala PTAL again, Thanks.

@lamxTyler

This comment has been minimized.

Show comment
Hide comment
@lamxTyler

lamxTyler Sep 8, 2017

Member

/run-all-test

Member

lamxTyler commented Sep 8, 2017

/run-all-test

@lamxTyler lamxTyler merged commit 504a3c4 into master Sep 8, 2017

3 of 4 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
ci/circleci Your tests passed on CircleCI!
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@lamxTyler lamxTyler deleted the xhb/predist branch Sep 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment