GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PTAL @zz-jason @breeswish @jackysp
*: rewrite builtin func greatest/least
Merge branch 'master' of https://github.com/pingcap/tidb into xhy/gre…
make golint happy
Is this related with greatest/least?
It is better to add a comment here.
It's a bug fix,
if we invoke evalString on a TimeExpr, it would raise an error.
Is this a bug fix? Any test covers this?
can we use evalTp instead of TypeClass ?
The modification will influence the implementation of getCmpType,
thus influence the functions which use it.
Better to change this together.
Merge branch 'master' into xhy/greatest
@jackysp @breeswish PTAL